RFR: 8254824: SignalHandlerMark have no purpose

Robbin Ehn rehn at openjdk.java.net
Fri Oct 16 07:01:18 UTC 2020


On Thu, 15 Oct 2020 22:54:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> // If crash protection is installed we may longjmp away and no destructors
>>   // for objects in this scope will be run.
>>   // So don't use any RAII utilities before crash protection is checked.
>> 
>> Since even if crash protection is installed it's not certain we will longjmp and you can trust destructors after we
>> checked crash protection. ?
>
> I'm not sure if only the call to `check_crash_protection` can trigger the long jump? If so then your version of the
> comment is better.

Yes only check_crash_protection() do the longjmp and only if it's the protected thread and on SIGSEGV/SIGBUS.

-------------

PR: https://git.openjdk.java.net/jdk/pull/677


More information about the hotspot-runtime-dev mailing list