RFR: 8254824: SignalHandlerMark have no purpose

[Thomas Stuefe]

On Thu, 15 Oct 2020 19:00:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> SignalHandlerMark increase and decrease _num_nested_signal, but it is never read.
>> We have no caller to is_inside_signal_handler().
>> 
>> Testing T1.
>
> Marked as reviewed by coleenp (Reviewer).

> So the code I was worried about is the code between JVM_handle_x_signal and calling report_and_die. There's a lot of
> duplicated code in JVM_handle_x_signal. I moved some of it but if we move more of it far away, it would be nice to know
> we aren't calling Thread::current() or some Mutex inside of the signal handler. That said, I'm ok with its deletion.

I see your point now, I agree with you that it could be useful information. But its very easy to re-introduce if we
want. We don't even need a RAII object, we could just increase the signal nesting level in javaSignalHandler() directly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/677