RFR: 8243583: Change 'final' error checks to throw ICCE

Harold Seigel hseigel at openjdk.java.net
Wed Oct 28 12:37:45 UTC 2020


On Wed, 28 Oct 2020 06:38:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this small change to throw IncompatibleClassChangeError exceptions instead of VerifyError exceptions for attempts to override Final classes and methods, as described in https://bugs.openjdk.java.net/browse/JDK-8243582.
>> 
>> The fix was tested with tiers 1-2 on Linux, Mac OSX, and Windows, tiers 3-5 on Linux x64, and running the JCK lang, vm, and api tests.
>> 
>> Thanks, Harold
>
> Looks good!
> 
> Thanks,
> David

Thanks David and Lois for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/885


More information about the hotspot-runtime-dev mailing list