RFR: JDK-8254189: Improve comments for StackOverFlow and fix in_xxx() functions [v2]

[Gerard Ziemski]

On Wed, 28 Oct 2020 10:22:38 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Marked as reviewed by dholmes (Reviewer).
>
> Ping... May I have a second review please? Its quite trivial.
> Patch was tested in our internal systems and no problems surfaced.

Very nice.

Personally I'd like to see additional:

  ASSERT_TRUE(so.in_stack_red_zone(so.stack_end()));
  ASSERT_TRUE(so.in_stack_yellow_zone(so.stack_red_zone_base()));
  ASSERT_TRUE(so.in_stack_reserved_zone(so.stack_yellow_zone_base()));

in the test, to drive home the point of the inclusion of the ranges, but that's a tiny nick pick.

-------------

PR: https://git.openjdk.java.net/jdk/pull/795