RFR: JDK-8254189: Improve comments for StackOverFlow and fix in_xxx() functions [v2]

[Thomas Stuefe]

On Wed, 28 Oct 2020 16:28:02 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Marked as reviewed by gziemski (Committer).
>
>> Very nice.
> 
> Thank you, Gerard.
> 
>> 
>> Personally I'd like to see additional:
>> 
>> ASSERT_TRUE(so.in_stack_red_zone(so.stack_end()));
>> ASSERT_TRUE(so.in_stack_yellow_zone(so.stack_red_zone_base()));
>> ASSERT_TRUE(so.in_stack_reserved_zone(so.stack_yellow_zone_base()));
>> 
>> in the test, to drive home the point of the inclusion of the ranges, but that's a tiny nick pick.
> 
> I can do this. Will have to reshape those a bit since there is no "in_yellow_zone" (I considered adding one for tests sake but then did not).
> 
> ...Thomas

... and StackOverFlow::stack_end() is private, so I cannot use it in ASSERT either...

-------------

PR: https://git.openjdk.java.net/jdk/pull/795