RFR: 8255005: Fix indentation levels in classFileParser.cpp [v2]

Coleen Phillimore coleenp at openjdk.java.net
Thu Oct 29 21:34:45 UTC 2020


On Thu, 29 Oct 2020 20:28:57 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this very small change to fix indentation in classFileParser.cpp and move the check for the PermittedSubclasses attribute inside of the "if (major_version >= 16)" block.
>> 
>> Fix was tested with tiers 1 and 2 on Linux, Mac OSX, and Windows, and tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8255005: Fix indentation levels in classFileParser.cpp

Changes requested by coleenp (Reviewer).

src/hotspot/share/classfile/classFileParser.cpp line 3896:

> 3894:           _nest_host = class_info_index;
> 3895: 
> 3896:         } else if (_major_version >= JAVA_16_VERSION) {

I don't understand why you changed it from >= 15 to >= 16.

-------------

PR: https://git.openjdk.java.net/jdk/pull/931


More information about the hotspot-runtime-dev mailing list