RFR: 8255005: Fix indentation levels in classFileParser.cpp [v2]

Coleen Phillimore coleenp at openjdk.java.net
Fri Oct 30 12:53:56 UTC 2020


On Fri, 30 Oct 2020 12:40:08 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> src/hotspot/share/classfile/classFileParser.cpp line 3896:
>> 
>>> 3894:           _nest_host = class_info_index;
>>> 3895: 
>>> 3896:         } else if (_major_version >= JAVA_16_VERSION) {
>> 
>> I don't understand why you changed it from >= 15 to >= 16.
>
> It was changed to 16 because, starting with 16, Records is a new non-preview feature.   So, the Record attribute is for class file version 60 or later.  60 is the major class file version for JDK-16.
> 
> Sealed types are still preview but require class file version 60.65535.   Preview features must always have the latest major class file version (and minor version of 655353).

Okay, thank you for the explanation about preview features.  Looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/931


More information about the hotspot-runtime-dev mailing list