Why do we export "JVM_handle_xxx_signal"?

[Coleen Phillimore]

On 10/30/20 8:58 AM, Thomas Stüfe wrote:
> Yes, I have a patch in preparation. Not the whole cleanup, but some of 
> the more obvious things. I need to get JDK-8252533 through first 
> (since I have not yet figured out how to post a PR based on another, 
> still open, PR).

I don't know how to do this yet either.  Thank you from the reviewers 
for doing one at a time.
Coleen

>
> Cheers, Thomas
>
> On Fri 30. Oct 2020 at 13:30, Coleen Phillimore 
> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
> wrote:
>
>
>     I looked through the old history and don't see any reason for this
>     naming.  My only guess is that the solaris version was exported to
>     the
>     JDK at one time.
>
>     It would be nice for these to have new names, and I see on the other
>     thread some of the code might be refactored?  That would be really
>     good.
>
>     Thanks,
>     Coleen
>
>     On 10/30/20 2:22 AM, Thomas Stüfe wrote:
>     > Thanks for checking, Ioi. I think I'll remove the export and
>     rename the
>     > functions.
>     >
>     > Cheers, Thomas
>     >
>     > On Fri, Oct 30, 2020 at 7:12 AM Ioi Lam <ioi.lam at oracle.com
>     <mailto:ioi.lam at oracle.com>> wrote:
>     >
>     >> I have no idea, but this symbol has been exported since we
>     moved the
>     >> HotSpot source code from SCCS to Mercurial in 2008. It's probably
>     >> vestige from the early days of Java.
>     >>
>     >>
>     >>
>     http://hg.openjdk.java.net/jdk7/modules/hotspot/annotate/9646293b9637/make/linux/makefiles/mapfile-vers-product#l244
>     <http://hg.openjdk.java.net/jdk7/modules/hotspot/annotate/9646293b9637/make/linux/makefiles/mapfile-vers-product#l244>
>     >>
>     >> I checked all .so files in our JDK build and no one uses
>     >> JVM_handle_linux_signal. I think it's probably safe to hide it. We
>     >> should probably drop the JVM_ prefix, since this function is not
>     >> declared in jvm.h.
>     >>
>     >> Thanks
>     >> - Ioi
>     >>
>     >> On 10/29/20 9:02 AM, Thomas Stüfe wrote:
>     >>> Hi,
>     >>>
>     >>> Does anyone know why we explicitly export
>     JVM_handle_bsd_signal and
>     >>> JVM_handle_linux_signal (the latter also accidentally from
>     symbols-aix)?
>     >>>
>     >>> These functions are not even the real signal handler, just an
>     internal
>     >>> function; the signal handler is "javaSignalHandler", but that
>     one is not
>     >>> exported...
>     >>>
>     >>> Thanks, Thomas
>     >>
>