RFR: 8252725: Refactor jlink GenerateJLIClassesPlugin code
Yumin Qi
yumin.qi at oracle.com
Fri Sep 4 16:49:18 UTC 2020
Hi, Alan
Thanks. Pushed before saw your email, could not credit you on reviewers.
Thanks
Yumin
On 9/4/20 2:10 AM, Alan Bateman wrote:
> On 04/09/2020 05:37, Yumin Qi wrote:
>> HI, Sundar
>>
>> Thanks for review.
>>
>> On 9/3/20 6:34 PM, sundararajan.athijegannathan at oracle.com wrote:
>>> Looks good to me.
>>>
>>> Few minor comment:
>>>
>>> * traceFileStream (and even the preexisting mainArgument) is accessed only inside GenerateJLIClassesPlugin. Could be private?
>>>
>> I will fix them before push. (Certainly will build first to verify that).
> I went through the refactoring of the jlink plugin and I think it looks good too.
>
> -Alan.
More information about the hotspot-runtime-dev
mailing list