RFR: 8244778: Archive full module graph in CDS [v2]

Ioi Lam iklam at openjdk.java.net
Wed Sep 9 21:58:24 UTC 2020


On Wed, 9 Sep 2020 18:41:25 GMT, Lois Foltan <github.com+66382410+lfoltan at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
>> the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last
>> revision:
>>  - Removed TODO comment referring to JBS issue
>>  - Merge branch 'master' into 8244778-archive-full-module-graph
>>  - fixed trailing spaces
>>  - Renamed ModuleEntry::write_growable_array
>>  - Update to latest repo (JDK-8251557); added comments
>>  - 8244778: Archive full module graph in CDS
>
> src/hotspot/share/oops/instanceKlass.cpp line 2550:
> 
>> 2548:   // clear _nest_host to ensure re-load at runtime
>> 2549:   _nest_host = NULL;
>> 2550:   _package_entry = NULL; // TODO -- point it to the archived PackageEntry (JDK-8249262)
> 
> Would you consider removing this comment?  I tend not to like TODO comments since sometimes the open enhancement
> remains unaddressed.

I removed the comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/80


More information about the hotspot-runtime-dev mailing list