RFR: 8252981: ObjectMonitor::object() cleanup changes extracted from JDK-8247281 [v2]
Daniel D.Daugherty
dcubed at openjdk.java.net
Thu Sep 10 18:42:51 UTC 2020
On Thu, 10 Sep 2020 18:30:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove left over setting of GVars.stw_random; fixed separately via JDK-8252126.
>
> src/hotspot/share/runtime/objectMonitor.inline.hpp line 102:
>
>> 100:
>> 101: inline oop ObjectMonitor::object() const {
>> 102: return (oop)_object;
>
> `cast_to_oop(_object)` here?
This function will change again with the next changeset (JDK-8247281)
so I'd rather stick with the C-style cast for this changeset.
> src/hotspot/share/runtime/objectMonitor.inline.hpp line 110:
>
>> 108:
>> 109: inline void ObjectMonitor::set_object(oop obj) {
>> 110: _object = (void*)obj;
>
> `cast_from_oop<void*>(obj)` here?
This function will change again with the next changeset (JDK-8247281)
so I'd rather stick with the C-style cast for this changeset.
-------------
PR: https://git.openjdk.java.net/jdk/pull/114
More information about the hotspot-runtime-dev
mailing list