RFR: 8244778: Archive full module graph in CDS [v4]

[Ioi Lam]

On Sat, 12 Sep 2020 12:34:06 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
>> the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last
>> revision:
>>  - Merge branch 'master' into 8244778-archive-full-module-graph
>>  - Feedback from Coleen
>>  - Removed TODO comment referring to JBS issue
>>  - Merge branch 'master' into 8244778-archive-full-module-graph
>>  - fixed trailing spaces
>>  - Renamed ModuleEntry::write_growable_array
>>  - Update to latest repo (JDK-8251557); added comments
>>  - 8244778: Archive full module graph in CDS
>
> src/hotspot/share/memory/heapShared.cpp line 76:
> 
>> 74: // assigned at runtime.
>> 75: static ArchivableStaticFieldInfo closed_archive_subgraph_entry_fields[] = {
>> 76:   {"java/lang/Integer$IntegerCache",              0, "archivedCache"},
> 
> Could the changes here be simplified or clarified? I think the new field should be a bool, or we could instead
> introduce a new array for the fields archived only when archiving the full module graph (the field is ignored on
> iteration over closed_archive_subgraph_entry_fields anyhow)

I split out the new fields into a separate array as you suggested. Also fixed the typos you found. See commit
[e987110](https://github.com/openjdk/jdk/pull/80/commits/e98711029879ffa21757ca871120ad7b17344d01).

-------------

PR: https://git.openjdk.java.net/jdk/pull/80