RFR: 8253089: Windows (MSVC 2017) build fails after JDK-8243208

Ioi Lam iklam at openjdk.java.net
Mon Sep 14 17:19:59 UTC 2020


On Mon, 14 Sep 2020 15:42:19 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> It seems that MSVC 2017 is getting confused about the differences in `unsigned int` and `u2`. After a few attempts at
>> fixing this, I think we need to use `u2` consistently for hash code computations. `u2` is the final storage type for
>> the hash code in `JVMFlagLookup::_hashes`.
>
> LGTM, Goetz.

I agree with Kim that it's better to disable the warning.

-------------

PR: https://git.openjdk.java.net/jdk/pull/150


More information about the hotspot-runtime-dev mailing list