RFR: 8253089: Windows (MSVC 2017) build fails after JDK-8243208
Aleksey Shipilev
shade at redhat.com
Mon Sep 14 17:43:35 UTC 2020
On 9/14/20 7:27 PM, Aleksey Shipilev wrote:
> On 9/14/20 6:05 PM, Kim Barrett wrote:
>> I think changing to using u2 isn't the right solution though. This throws
>> away a lot of bits in the hash-code calculation, potentially making it less
>> effective.
>
> I think this accuracy concern does not apply here, because it does not actually change the computation.
>
> [...]
>
> Or try this ;)
> https://cr.openjdk.java.net/~shade/8253089/mod-hashcode.cpp
Even more: jvmFlagLookup.o files before and after are bit-to-bit identical. (I objdumped to look at
.rodata section to see _flag_lookup_table is there).
--
Thanks,
-Aleksey
More information about the hotspot-runtime-dev
mailing list