RFR: 8247281: migrate ObjectMonitor::_object to OopStorage [v4]

Daniel D.Daugherty dcubed at openjdk.java.net
Mon Sep 14 21:09:57 UTC 2020


On Mon, 14 Sep 2020 21:02:51 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> I agree. Also, the assert becomes true somewhat obviously because of its first clause, which is already guaranteed
>> because of its placement in the surrounding else-branch (unless something really weird happens).
>
> I am also 100% okay with just removing the random assertion. We have a whole bunch of other block iteration code in GC
> code that does not sprinkle random asserts about what patterns of markWords are supposedly good or bad in live/dead
> objects. And I also don't get what kind of bug this would catch.

Okay. Since @coleenp, @rkennke and @fisk want that assertion to "hit the road",
I'm in the process of removing it... build running now (just 'cause I'm paranoid me...)...

-------------

PR: https://git.openjdk.java.net/jdk/pull/135


More information about the hotspot-runtime-dev mailing list