RFR: 8252921: NMT overwrite memory type for region assert when building dynamic archive
Yumin Qi
minqi at openjdk.java.net
Tue Sep 15 17:12:40 UTC 2020
On Tue, 15 Sep 2020 14:37:44 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
> Thread stack is currently unregistered with NMT in Thread's destructor. Apparently, only Java thread invokes destructor
> before thread exits. For NonJavaThread, e.g. ConcurrentGCThread, thread may exit while its "Thread" object continues
> alive, therefore, its thread stack is still "alive" from NMT perspective. Once thread exits, the virtual memory for the
> thread stack can be reserved again, that confused NMT. The solution is to move thread stack unregistration code to
> post_run() method.
Looks good.
-------------
Marked as reviewed by minqi (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/185
More information about the hotspot-runtime-dev
mailing list