RFR: 8249451: Unconditional exceptions clearing logic in compiler code should honor Async Exceptions. [v2]

[David Holmes]

On Tue, 15 Sep 2020 10:59:06 GMT, Jamsheed Mohammed C M <jcm at openjdk.org> wrote:

>> Hi
>> 
>> Moving the review that is based on mercurial repo to github.
>> The history of conversation is
>> [here](https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039861.html)
>> Issue:[ JDK-8249451 ](https://bugs.openjdk.java.net/browse/JDK-8249451)
>> 
>> @dholmes-ora could you please have a look.
>
> Jamsheed Mohammed C M has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removing unused definition load_class_by_index

Looks good to me! No further comments.

src/hotspot/share/runtime/thread.cpp line 2392:

> 2390:   if (check_unsafe_error &&
> 2391:       condition == _async_unsafe_access_error && !has_pending_exception()) {
> 2392:     // May be we are at method entry and requires to save do not unlock flag.

Suggest:
// We may be at method entry which requires we save the do-not-unlock flag.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/169