RFR: 8253089: Windows (MSVC 2017) build fails after JDK-8243208

Aleksey Shipilev shade at openjdk.java.net
Wed Sep 16 11:24:03 UTC 2020


On Mon, 14 Sep 2020 22:25:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> It seems that MSVC 2017 is getting confused about the differences in `unsigned int` and `u2`. After a few attempts at
>> fixing this, I think we need to use `u2` consistently for hash code computations. `u2` is the final storage type for
>> the hash code in `JVMFlagLookup::_hashes`.
>
> Marked as reviewed by iklam (Reviewer).

I don't mind reverting this change, but it would break MSVC 2017 again, until we push the pragmas. Unfortunately, I
lost the capability to build with MSVC 2017, so maybe we should ask SAP folks (who IIRC still have their pipelines with
MSVC 2017) to verify this still works.

-------------

PR: https://git.openjdk.java.net/jdk/pull/150


More information about the hotspot-runtime-dev mailing list