RFR: 8252921: NMT overwrite memory type for region assert when building dynamic archive [v2]

Zhengyu Gu zgu at openjdk.java.net
Wed Sep 16 15:13:08 UTC 2020


> Thread stack is currently unregistered with NMT in Thread's destructor. Apparently, only Java thread invokes destructor
> before thread exits.  For NonJavaThread, e.g. ConcurrentGCThread, thread may exit while its "Thread" object continues
> alive, therefore, its thread stack is still "alive" from NMT perspective. Once thread exits, the virtual memory for the
> thread stack can be reserved again, that confused NMT.  The solution is to move thread stack unregistration code to
> post_run() method.

Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:

  Restore assertion

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/185/files
  - new: https://git.openjdk.java.net/jdk/pull/185/files/f4fbe38b..467db25a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=185&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=185&range=00-01

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/185.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/185/head:pull/185

PR: https://git.openjdk.java.net/jdk/pull/185


More information about the hotspot-runtime-dev mailing list