RFR: 8249451: Unconditional exceptions clearing logic in compiler code should honor Async Exceptions. [v4]

[Igor Veresov]

On Wed, 16 Sep 2020 09:36:28 GMT, Jamsheed Mohammed C M <jcm at openjdk.org> wrote:

>> Hi
>> 
>> Moving the review that is based on mercurial repo to github.
>> The history of conversation is
>> [here](https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039861.html)
>> Issue:[ JDK-8249451 ](https://bugs.openjdk.java.net/browse/JDK-8249451)
>> 
>> @dholmes-ora could you please have a look.
>
> Jamsheed Mohammed C M has refreshed the contents of this pull request, and previous commits have been removed. The
> incremental views will show differences compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>   comment modified wrt review feedback

src/hotspot/share/prims/whitebox.cpp line 1056:

> 1054:
> 1055:   // Compile method and check result
> 1056:   nmethod* nm = CompileBroker::compile_method(mh, bci, comp_level, mh, mh->invocation_count(),
> CompileTask::Reason_Whitebox, CHECK_false);

Shouldn't this be CHECK_NULL ? The function returns a pointer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/169