RFR: 8249451: Unconditional exceptions clearing logic in compiler code should honor Async Exceptions. [v4]

Igor Veresov iveresov at openjdk.java.net
Fri Sep 18 05:34:30 UTC 2020


On Fri, 18 Sep 2020 05:29:36 GMT, Jamsheed Mohammed C M <jcm at openjdk.org> wrote:

>> src/hotspot/share/prims/whitebox.cpp line 1056:
>> 
>>> 1054:
>>> 1055:   // Compile method and check result
>>> 1056:   nmethod* nm = CompileBroker::compile_method(mh, bci, comp_level, mh, mh->invocation_count(),
>>> CompileTask::Reason_Whitebox, CHECK_false);
>> 
>> Shouldn't this be CHECK_NULL ? The function returns a pointer.
>
> bool WhiteBox::compile_method returns a bool

Yes, you're right of course. Reviewed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/169


More information about the hotspot-runtime-dev mailing list