RFR: 8253241: Update comment on java_suspend_self_with_safepoint_check()

Daniel D.Daugherty dcubed at openjdk.java.net
Fri Sep 18 21:52:28 UTC 2020


On Thu, 17 Sep 2020 13:57:04 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

> After JDK-8252414 the safepoint/handshake code does not take _suspend_flags into accout anymore in its assessment if a
> thread is safepoint/handshake safe. This change updates the comment on
> JavaThread::java_suspend_self_with_safepoint_check().  I have (not yet) fixed the line breaks (fill-paragraph in emacs
> lingo) for a clearer diff.
> Also I could inline the (*) footnote.

The updated wording in the comment looks good to me.

I still get a headache when thinking about the associated
suspend/resume races, but that's my problem and not yours.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/225


More information about the hotspot-runtime-dev mailing list