RFR: 8238761: Asynchronous handshakes [v3]

Robbin Ehn rehn at openjdk.java.net
Mon Sep 21 10:05:32 UTC 2020


On Fri, 18 Sep 2020 20:37:10 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed double check, fix comment, removed not needed function, updated logs
>
> src/hotspot/share/runtime/thread.cpp line 487:
> 
>> 485:   assert(!thread->is_Java_thread() ||
>> 486:          ((JavaThread *) thread)->is_handshake_safe_for(Thread::current()) ||
>> 487:          !((JavaThread *) thread)->on_thread_list() ||
> 
> Should use "thread->as_Java_thread()" instead of the cast here (2 places).

Fixed

> src/hotspot/share/runtime/thread.hpp line 1360:
> 
>> 1358:   bool is_handshake_safe_for(Thread* th) const {
>> 1359:     return _handshake.active_handshaker() == th ||
>> 1360:            this == th;
> 
> I _think_ L1359-60 will fit on one line...

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/151


More information about the hotspot-runtime-dev mailing list