Integrated: 8253447: Remove buggy code introduced by 8249451

Jamsheed Mohammed C M jcm at openjdk.java.net
Tue Sep 22 06:29:39 UTC 2020


On Tue, 22 Sep 2020 01:48:53 GMT, Jamsheed Mohammed C M <jcm at openjdk.org> wrote:

> if ((thread->has_pending_exception() || thread->frames_to_pop_failed_realloc() > 0) && exec_mode !=
> Unpack_uncommon_trap) {
>     assert(thread->has_pending_exception(), "should have thrown OOME/Async");
> 
> introduced a buggy code checking, clearing pending exception and taking Unpack_exception route.
> 
> This can have consequences as the deopt entries may have additional logic depending on bci's. and the change introduced
> in 8249451 doesn't honor deopt exception checking and forward logic. Thank you @fisk  for pointing the bug in the code.
> Request for review.

This pull request has now been integrated.

Changeset: f7b1ce45
Author:    Jamsheed Mohammed C M <jcm at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/f7b1ce45
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8253447: Remove buggy code introduced by 8249451

Reviewed-by: iveresov, eosterlund

-------------

PR: https://git.openjdk.java.net/jdk/pull/292


More information about the hotspot-runtime-dev mailing list