RFR: 8253572: [windows] CDS archive may fail to open with long file names

Calvin Cheung ccheung at openjdk.java.net
Thu Sep 24 21:02:13 UTC 2020


On Thu, 24 Sep 2020 10:04:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Hi all,
> 
> there is a long standing bug in the windows version of os::pd_map_memory() which may cause it to fail if the path to
> the underlying file is longer than the OS limit. This is mainly of interest for CDS, which uses this functionality to
> map in sections of the archive into the memory. This bug may cause the CDS mapping to fail. See also
> https://bugs.openjdk.java.net/browse/JDK-8249943.  As with similar cases, the fix is to translate the input file name
> to a wide character UNC path name and use the Unicode variant of CreateFile which accepts long path names.

Thanks for identifying the bug and fixing it. The patch looks good.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/332


More information about the hotspot-runtime-dev mailing list