RFR: 8253397: Ensure LogTag types are sorted [v2]

[David Holmes]

On Thu, 24 Sep 2020 09:00:55 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> @dholmes-ora: fwiw, there is: click on the actual commit link (e.g.
>> https://github.com/openjdk/jdk/pull/274/commits/19d37e729150dc330efbd494ef4e3a08b3017886 in this case where it says "
>> cl4es added 2 commits 4 days ago ") and you'll get a diff in github. There is an enhancement/bug open on skara for
>> better support of diffs for force pushes.
>
> @dholmes-ora once I ended up in a state where force-push seemed like the only option it was too late. I assure you
> there were no changes from the reviewed changeset, and since there were no inline comments little I figured little was
> lost.  I believe a `git rebase` was the cause of this, and will use `git merge` in my workflow instead. I got into the
> habit of continually rebasing rather than merging in mercurial in order to avoid merge commits, but here those will be
> squashed anyhow. I will refrain from rebasing after opening a PR from now on.

> @dholmes-ora: fwiw, there is: click on the actual commit link (e.g.
> [19d37e7](https://github.com/openjdk/jdk/commit/19d37e729150dc330efbd494ef4e3a08b3017886) in this case where it says "
> cl4es added 2 commits 4 days ago ") and you'll get a diff in github. There is an enhancement/bug open on skara for
> better support of diffs for force pushes.

That is a diff for one of the commits that was force-pushed over the original. I can see diffs both of those commits
but what I cannot see is how those commits differ to the original one that was overwritten. Further if I click on "Show
changes since your last review" I get an error page:

"We went looking everywhere, but couldn’t find those commits.
Sometimes commits can disappear after a force-push. Head back to the latest changes here."

We don't need better support for forced pushes IMO we just need to not do them. Cheers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/274