RFR: 8253429: Error reporting should report correct state of terminated/aborted threads
Zhengyu Gu
zgu at openjdk.java.net
Fri Sep 25 13:44:30 UTC 2020
On Fri, 25 Sep 2020 13:21:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> > Hi Thomas and David,
> > I did notice the dead code (no one sets osthread's state to ZOMBIE before this patch) and plan to file a separate CR.
> > I don't quite understand the race condition you described above.
> > My understanding is that, os::create_thread() starts native thread, but it blocks until os::start_thread() to unblock
> > it. Therefore, there is no chance for os::create_thread() to see ZOMBIE state. What do I miss?
>
> Nothing, I just missed the double handshake. Sorry for the noise.
>
> > Thanks.
>
> Okay, the fix looks fine to me then.
Thanks, Thomas.
I filed JDK-8253647 to remove dead code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/341
More information about the hotspot-runtime-dev
mailing list