RFR: 8251158: Implementation of JEP 387: Elastic Metaspace [v2]

[Leo Korinth]

On Mon, 28 Sep 2020 11:15:30 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove empty lines from include sections
>
> I just have a few cosmetic comments. Otherwise it looks good to me.
> 
> If you sort by ASCII order, I get a few unordered includes:
> ("." < "/" < "a-z,A-Z")
> 
> 
> In file b/src/hotspot/share/gc/shared/genCollectedHeap.cpp:
> [not sorted]:
> #include "memory/metaspaceCounters.hpp" (Context)
> #include "memory/metaspace/metaspaceSizesSnapshot.hpp" (Addition)
> #include "memory/resourceArea.hpp" (Context)
> 
> In file b/src/hotspot/share/memory/metaspace.cpp:
> [not sorted]:
> #include "memory/metaspace/virtualSpaceList.hpp" (Context)
> #include "memory/metaspace.hpp" (Addition)
> #include "memory/metaspaceShared.hpp" (Context)
> 
> In file b/src/hotspot/share/memory/metaspace/chunkManager.cpp:
> [not sorted]:
> #include "memory/metaspace/metaspaceCommon.hpp" (Context)
> #include "memory/metaspace/metaspaceContext.hpp" (Addition)
> #include "memory/metaspace/metachunk.hpp" (Addition)
> 
> In file b/src/hotspot/share/memory/metaspace/chunkManager.cpp:
> [not sorted]:
> #include "memory/metaspace/metaspaceContext.hpp" (Addition)
> #include "memory/metaspace/metachunk.hpp" (Addition)
> #include "memory/metaspace/metaspaceSettings.hpp" (Addition)
> 
> 
> blockTree.hpp
> add a space after loop keyword "for(;;) {" -> "for (;;) {"
> 
> blockTree.cpp
> add a space after loop keyword "} while(0)" -> "} while (0)" (twice in file)
> 
> I still think we should try to get the initializer list indented
> somewhat consistently. (This is really boring, and hard as we do not
> have precise indentation rules and no mechanical indenter). Sorry for
> mentioning this, but now might be the time to get indentation
> consistent at least in metaspace. The indentation level seems to most
> often be 2 or 4. Sometimes "Haskell" indentation with "," at the
> beginning of each line is used (I like this, but I think I am in a
> small minority) and most often it is not used. Sometimes several field
> members are initialised on multi line initializer lists, sometimes
> only one per line (I prefer one per line, if not all fits on a single
> line). Open curly braces seem to mostly (but not always) be on a new line.
> 
> If you could normalize the style I would be happy, I yield my own
> preferences to you and the other reviewers on what style to use, so
> that we have a possibility to agree :-)
> 
> Thanks, Leo

Regarding the order of "." and "/" take what you prefer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/336