RFR: 8252324: Signal related code should be shared among POSIX platforms [v4]

[Gerard Ziemski]

On Mon, 28 Sep 2020 04:10:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert "Add AIX specific SA code"
>>   
>>   This reverts commit cc13700d7d3f15927e22d92d9f5ec9a0739ef9a1.
>
> src/hotspot/os/posix/signals_posix.cpp line 1310:
> 
>> 1308:
>> 1309: address PosixSignals::ucontext_get_pc(const ucontext_t* ctx) {
>> 1310: #if defined(AIX)
> 
> Again there must be a better way to do this dispatch. If the target were os::ucontext_get_pc, defined is os<os>.cpp
> then we would link to the current platforms version.

Will be addressed in JDK-8253742

> src/hotspot/os/posix/signals_posix.cpp line 46:
> 
>> 44: // suspend/resume
>> 45:
>> 46: // glibc on Bsd platform uses non-documented flag
> 
> This was added for Linux and then copied to the BSD port, so the comment is inaccurate. This seems to be referring to
> the SA_RESTORER flag which seems to be a linux kernel flag. But I'm unsure why we would need to even be aware of this.
> I think future cleanup could be done here.

Will be addressed in JDK-8253742

-------------

PR: https://git.openjdk.java.net/jdk/pull/157