RFR: 8253429: Error reporting should report correct state of terminated/aborted threads

[Thomas Stuefe]

On Thu, 24 Sep 2020 18:14:10 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> For some non-JavaThread, their object instances can outlast threads' lifespan. For example, we still can query/report
> thread's state after thread terminated.
> But the query/report currently returns wrong state. E.g. a terminated thread appears to be alive and seemly has valid
> thread stack, etc.
> This patch sets non-JavaThread's state to ZOMBIE just before it terminates, so that we can distinguish terminated
> thread from live thread.
> Also, thread should not report its SMR info, if it has terminated or it never started (thread->osthread() == NULL).
> 
> Note: Java thread does not have such issue, its thread object is deleted before thread terminates.

Hi Zhengyu,

I'm updating my review after reading through your conversation with David. Save for small nits this seem fine.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/341