RFR: 8246774: implementing Record Classes as a standard feature in Java [v3]

[Chris Hegarty]

On Wed, 23 Sep 2020 08:54:57 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Merge pull request #1 from ChrisHegarty/record-serial-tests
>>    
>>    Remove preview args from JDK tests
>>  - Remove preview args from ObjectMethodsTest
>>  - Remove preview args from record serialization tests
>
> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
> 
>> 31:  *          jdk.compiler/com.sun.tools.javac.util
>> 32:  * @build combo.ComboTestHelper
>> 33:  * @compile LocalStaticDeclarations.java
> 
> This, and other, explicit at compile tags could be elided, no? The test source file will be implicitly compiled by the
> at run tag. I believe that the explicit at compile tag was added original so that the enable preview and source version
> options could be passed to javac - neither of which are needed any more.

Does this test need an @run tag rather than an @compile tag ?  ( the @run with implicitly compile the source file,
before running it )

-------------

PR: https://git.openjdk.java.net/jdk/pull/290