RFR: 8246774: implementing Record Classes as a standard feature in Java [v3]

[Vicente Romero]

On Wed, 30 Sep 2020 08:54:14 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33:
>> 
>>> 31:  *          jdk.compiler/com.sun.tools.javac.util
>>> 32:  * @build combo.ComboTestHelper
>>> 33:  * @compile LocalStaticDeclarations.java
>> 
>> This, and other, explicit at compile tags could be elided, no? The test source file will be implicitly compiled by the
>> at run tag. I believe that the explicit at compile tag was added original so that the enable preview and source version
>> options could be passed to javac - neither of which are needed any more.
>
> Does this test need an @run tag rather than an @compile tag ?  ( the @run with implicitly compile the source file,
> before running it )

yep u are right it could be removed, I will check all the instances of this, thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/290