RFR: 8252324: Signal related code should be shared among POSIX platforms [v5]

Gerard Ziemski gziemski at openjdk.java.net
Wed Sep 30 22:52:44 UTC 2020


On Wed, 30 Sep 2020 22:42:16 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Gerard, this is a great cleanup. I am fine with the changes.
>> 
>> This will make maintenance of ports easier. As we see right in this patch, platform ports can diverge over time,
>> especially if they are closed ports which only exist downstream (as the AIX port did for a long time at SAP).
>> .. Thomas
>
>> Gerard, this is a great cleanup. I am fine with the changes.
>> 
>> This will make maintenance of ports easier. As we see right in this patch, platform ports can diverge over time,
>> especially if they are closed ports which only exist downstream (as the AIX port did for a long time at SAP).
>> .. Thomas
> 
> Thank you Martin for the review!

Sorry for taking so long, but this is my 1st github pr and I did not liked the merge issues that David discovered and
tried to redo the merge, but I keep getting it wrong.

I just forced pushed update removing the BIG merge and I keep working on it, hopefully without introducing another huge
merge. If anyone has tips on how to apply local changes (i.e. rebase/stash?) without having to merge, please let me
know.

Once I figure this out, I will re-implement the few, non-merge, issues that David discovered and this will be ready for
integration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/157


More information about the hotspot-runtime-dev mailing list