RFR: 8264393: JDK-8258284 introduced dangling TLH race [v3]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Apr 1 17:19:22 UTC 2021


On Thu, 1 Apr 2021 07:17:20 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   dholmes CR - fix nit in assert mesg.
>
> Marked as reviewed by rehn (Reviewer).

@robehn - Thanks for closing the loop on your review thread.

@dholmes-ora nutshell summary covers it:
when clearing a nested TLH you can't simply install the previous TLH as the threads_hazard_ptr, but instead set to NULL so that it is properly set by acquire_stable_list.

Another way to put it is that the `_threads_hazard_ptr` field must only be set to
a non-NULL value by the acquire_stable_list() protocol.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3272


More information about the hotspot-runtime-dev mailing list