RFR: 8264482: container info misleads on non-container environment

Yasumasa Suenaga ysuenaga at openjdk.java.net
Fri Apr 2 00:08:07 UTC 2021


On Thu, 1 Apr 2021 13:00:32 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> Thanks @jerboaa and @dholmes-ora for the comment!
>> I haven't aware JDK-8261242, so I will remove the code to set container runtime name.
>> 
>> The reason why I sent this PR is I found "container_type" in hs_err log even though I did not run JVM on the container. It was confising. I agree to check cgroups configuration, but we should not use "container" for them. cgroups is not only for containers.
>> 
>>> Did you run tests in test/hotspot/jtreg/containers ?
>> 
>> I haven't run them yet. I attempted to fix `OSContainer::is_containerized()` as JDK-8261242 said, but I do not have environment to run test/hotspot/jtreg/containers test. So I fixed UL output only, and confirmed it does not affect their tests.
>
> I removed container runtime detection code - this PR changes log / hs_err / VM.info message only at result.
> How about this? please review it.

Commit 8fd9b3f95d40783ef3b70769ba0381f55df832a5 seems to fail on macOS x64 (hs/tier1 compiler) tests, but I think it is not caused by this change because I modified Linux code only.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3280


More information about the hotspot-runtime-dev mailing list