RFR: 8264731: Introduce InstanceKlass::method_at_itable_or_null()

Coleen Phillimore coleenp at openjdk.java.net
Tue Apr 6 02:05:23 UTC 2021


On Mon, 5 Apr 2021 17:40:58 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> Introduce `InstanceKlass::method_at_itable_or_null()` - a non-throwing variant of `InstanceKlass::method_at_itable()` that implements interface method selection. 
> 
> As a cleanup, rewrite `InstanceKlass::method_at_itable()` on top of `InstanceKlass::method_at_itable_or_null()`.
> 
> Testing: 
> * [x] hs-tier1 - hs-tier6

This is a lot clearer than existing code.  I don't see the caller other than mehod_at_itable() though.

src/hotspot/share/oops/instanceKlass.cpp line 3179:

> 3177: 
> 3178: Method* InstanceKlass::method_at_itable_or_null(InstanceKlass* holder, int index, bool& itable_entry_found) {
> 3179:   klassItable itable(this);

I think  you need a ResourceMark before this.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3344


More information about the hotspot-runtime-dev mailing list