RFR: 8264731: Introduce InstanceKlass::method_at_itable_or_null() [v2]

David Holmes dholmes at openjdk.java.net
Wed Apr 7 05:29:40 UTC 2021


On Tue, 6 Apr 2021 13:01:53 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Introduce `InstanceKlass::method_at_itable_or_null()` - a non-throwing variant of `InstanceKlass::method_at_itable()` that implements interface method selection. 
>> 
>> As a cleanup, rewrite `InstanceKlass::method_at_itable()` on top of `InstanceKlass::method_at_itable_or_null()`.
>> 
>> Testing: 
>> * [x] hs-tier1 - hs-tier6
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanups

Update looks good - thanks - but I'd like to see it extend a little further.

Thanks,
David

src/hotspot/share/oops/instanceKlass.cpp line 3180:

> 3178: }
> 3179: 
> 3180: Method* InstanceKlass::method_at_itable_or_null(InstanceKlass* holder, int index, bool& itable_entry_found) {

The change to use implements_interface applies in here too. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3344


More information about the hotspot-runtime-dev mailing list