RFR: 8257831: Suspend with handshakes [v3]

[Robbin Ehn]

On Wed, 31 Mar 2021 05:03:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/handshake.cpp line 415:
> 
>> 413:   // Adds are done lock free and so is arming.
>> 414:   // Calling this method with lock held is considered an error.
>> 415:   assert(!_lock.owned_by_self(), "Lock should not be held");
> 
> If adds are still lock-free then why was this assertion removed?

Because we add the async handshake inside the sync handshake and thus we already hold the _lock.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191