RFR: 8264412: AArch64: CPU description should refer DMI [v3]

[Andrew Haley]

On Wed, 31 Mar 2021 13:31:19 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> One other thing I missed last time around: why is there a permanently-allocated 4k buffer for this code that it only used for jfr?
>
> I pushed new commit with some refactoring.
> 
>> Please be more explicit. This is (perhaps obviously?) a workaround for a bug, And t.his code is itself a bug, because it doesn't check for the condition you care about. So, please check explicitly for this condition: \n only, and nothing else. And leave a comment explaining why.
> 
> I've done so in new commit.
> 
>> One other thing I missed last time around: why is there a permanently-allocated 4k buffer for this code that it only used for jfr?
> 
> Some features (e.g. hs_err log, VM.info dcmd) dumps /proc/cpuinfo, so I guess this feature is used JFR only now. However CPU description has different information (for AArch64 at least), so we might be able to use it in other place, but it is out of scope this PR.

Looks better. I guess the problem here is that we don't know how robust we need to make this against future bugs.
Maybe we should just concatenate all three files?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3259