RFR: 8264732: Clean up LinkResolver::vtable_index_of_interface_method() [v2]

Vladimir Ivanov vlivanov at openjdk.java.net
Wed Apr 7 21:47:59 UTC 2021


On Wed, 7 Apr 2021 05:32:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert jvmciCompilerToVM.cpp change.
>
> Seems quite reasonable - though unsure of the motivation.
> 
> Do we need a NoSafepointVerifier in LinkResolver::vtable_index_of_interface_method to ensure the raw Method* remains valid?
> 
> Thanks,
> David

Thinking more about it, `methodHandle` does look more natural than a raw `Method*` on `LinkResolver`.

What do you think about leaving `LinkResolver` as it is now and move `vtable_index_of_interface_method` implementation to `InstanceKlass` instead?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3346


More information about the hotspot-runtime-dev mailing list