RFR: 8264732: Clean up LinkResolver::vtable_index_of_interface_method() [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Apr 7 23:04:06 UTC 2021


On Wed, 7 Apr 2021 21:41:58 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Turn `resolved_method` parameter into raw `Method*`.
>> 
>> Testing:
>> * [x] hs-tier1 - hs-tier6
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move itable_index_of_interface_method() implementation to InstanceKlass

src/hotspot/share/oops/instanceKlass.cpp line 3199:

> 3197:   // First check in default method array
> 3198:   if (!intf_method->is_abstract() && this->default_methods() != NULL) {
> 3199:     int index = InstanceKlass::find_method_index(this->default_methods(),

Yes, please, this looks a lot better!  Then linkResolver can deal with methodHandle consistently so it doesn't go away with redefinition, and this function is nice here with the other like functions.
It doesn't need InstanceKlass:: before find_method_index, or the this->'s.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3346


More information about the hotspot-runtime-dev mailing list