RFR: 8264672: runtime/ParallelLoad/ParallelSuperTest.java timed out [v2]

[David Holmes]

On Wed, 7 Apr 2021 15:34:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Added a flag so that thread 2 will notify thread 1 after it's waiting, and not before.
>> Ran 100x on macosx-x64-debug without timeout (actually ran original 100x without timeout also).
>> The test relies on one thread waiting at a place where another can find the class loading in progress.  Alternate suggestions welcome.
>> Thanks!
>> Coleen
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add volatile

Hi Coleen,

The synchronization in this test is highly suspect, but your change certainly helps address one of the race conditions.

Thanks,
David

test/hotspot/jtreg/runtime/ParallelLoad/MyLoader.java line 64:

> 62:     private Object sync = new Object();
> 63:     private Object thread_sync = new Object();
> 64:     private static volatile boolean ready = false;

The name "waiting" would be more appropriate.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3375