RFR: 8264997: Remove SystemDictionary::cache_get [v2]

[Harold Seigel]

On Fri, 9 Apr 2021 18:31:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a trivial change to remove an unneeded function in SystemDictionary.  The pd_cache_table() that is owned by SystemDictionary is already available to callers of SystemDictionary, ie. the ServiceThread, so there's no need to hide access inside of a function with a backwards name.
>> 
>> I also fixed add_protection_domain logging to be useful and fixed an assert.
>> 
>> Tested with mach5 tier1-3 in progress and manually.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missed fixing logging test.

These changes look good and trivial.
Thanks, Harold

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3418