RFR: 8265035: Remove unneeded exception check from refill_ic_stubs() [v2]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Tue Apr 13 02:29:17 UTC 2021


> Hi,
> 
> Please review this small fix. The HAS_PENDING_EXCEPTION check will always return false since EXCEPTION_MARK will check that there are no pending exceptions upon entering and VMThread::execute() doesn't throw exceptions.
> The comment says that we could get a potential async exception, which is true, since the JT will be blocked waiting on VMOperation_lock. However delivering an async exception doesn't set the _pending_exception field, only additional fields (see JavaThread::send_thread_stop() -> set_pending_async_exception()) that will be later check in check_and_handle_async_exceptions() and only then _pending_exception will be set.
> 
> Thanks,
> Patricio

Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:

  Remove EXCEPTION_MARK

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3436/files
  - new: https://git.openjdk.java.net/jdk/pull/3436/files/76dbae73..c2f3fdf0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3436&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3436&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3436.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3436/head:pull/3436

PR: https://git.openjdk.java.net/jdk/pull/3436


More information about the hotspot-runtime-dev mailing list