RFR: 8257831: Suspend with handshakes [v6]

[Robbin Ehn]

On Mon, 12 Apr 2021 20:51:17 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Review fixes 2
>>  - White space fixes
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Review fixes
>>  - Merge branch 'master' into SuspendInHandshake
>>  - Merge branch 'master' into SuspendInHandshake
>>  - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/handshake.cpp line 466:
> 
>> 464:     // The exception to this rule is the asynchronous suspension handshake.
>> 465:     // It by-passes the NSV by manully doing the transition.
>> 466:     // Since we can have safepoints while suspeneded we need to release the tty locker if it is held.
> 
> nit typo: s/manully/manually/
> nit typo: s/suspeneded/suspended/

Fixed

> src/hotspot/share/runtime/handshake.hpp line 133:
> 
>> 131:     // check the _lock, if held go to slow path.
>> 132:     // Since the handshakee is unsafe if _lock gets lock after this check
>> 133:     // we know another threads cannot process any handshakes.
> 
> nit typo: s/_lock gets lock/_lock gets locked/
> nit typo: s/threads/thread/

Fixed

> src/hotspot/share/runtime/thread.cpp line 1448:
> 
>> 1446:     // The careful dance between thread suspension and exit is handled here.
>> 1447:     // Since we are in vm and suspension is done with handshakes,
>> 1448:     // we can just put in the exiting state and it will be corrcetly handled.
> 
> Perhaps: s/Since we are in vm and/Since we are in thread_in_vm state and/
> nit typo: s/corrcetly/correctly/

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3191