RFR: 8265113: ProblemList gtest/GTestWrapper.java:os.release_multi_mappings on macosx-aarch64

Daniel D.Daugherty dcubed at openjdk.java.net
Tue Apr 13 14:06:01 UTC 2021


On Tue, 13 Apr 2021 07:04:39 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> Let's do the equivalent of problem listing the gtest/GTestWrapper.java os.release_multi_mappings sub-test (included in tier1) until JDK-8262952 is fixed.
> 
> Note: I considered a few different ways of disabling the test on macosx-aarch64. The gtest docs (https://github.com/google/googletest/blob/master/docs/advanced.md#temporarily-disabling-tests) note, and I agree, that adding the DISABLED_ prefix is preferable over preprocessor excluding the whole test. There are several ways to add the DISABLED_ prefix conditionally, only on macosx-aarch64. In the end I found this the easiest to read and understand.

I like this platform dependent technique.
This is a trivial fix and does not need to wait for 24 hours.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3454


More information about the hotspot-runtime-dev mailing list