Integrated: 8265113: ProblemList gtest/GTestWrapper.java:os.release_multi_mappings on macosx-aarch64
Mikael Vidstedt
mikael at openjdk.java.net
Tue Apr 13 15:13:59 UTC 2021
On Tue, 13 Apr 2021 07:04:39 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> Let's do the equivalent of problem listing the gtest/GTestWrapper.java os.release_multi_mappings sub-test (included in tier1) until JDK-8262952 is fixed.
>
> Note: I considered a few different ways of disabling the test on macosx-aarch64. The gtest docs (https://github.com/google/googletest/blob/master/docs/advanced.md#temporarily-disabling-tests) note, and I agree, that adding the DISABLED_ prefix is preferable over preprocessor excluding the whole test. There are several ways to add the DISABLED_ prefix conditionally, only on macosx-aarch64. In the end I found this the easiest to read and understand.
This pull request has now been integrated.
Changeset: fced0f08
Author: Mikael Vidstedt <mikael at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/fced0f08
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
8265113: ProblemList gtest/GTestWrapper.java:os.release_multi_mappings on macosx-aarch64
Reviewed-by: stuefe, akozlov, dcubed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3454
More information about the hotspot-runtime-dev
mailing list