Integrated: 8265035: Remove unneeded exception check from refill_ic_stubs()

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Tue Apr 13 15:36:00 UTC 2021


On Mon, 12 Apr 2021 14:46:02 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi,
> 
> Please review this small fix. The HAS_PENDING_EXCEPTION check will always return false since EXCEPTION_MARK will check that there are no pending exceptions upon entering and VMThread::execute() doesn't throw exceptions.
> The comment says that we could get a potential async exception, which is true, since the JT will be blocked waiting on VMOperation_lock. However delivering an async exception doesn't set the _pending_exception field, only additional fields (see JavaThread::send_thread_stop() -> set_pending_async_exception()) that will be later check in check_and_handle_async_exceptions() and only then _pending_exception will be set.
> 
> Thanks,
> Patricio

This pull request has now been integrated.

Changeset: 943503ef
Author:    Patricio Chilano Mateo <pchilanomate at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/943503ef
Stats:     9 lines in 1 file changed: 0 ins; 9 del; 0 mod

8265035: Remove unneeded exception check from refill_ic_stubs()

Reviewed-by: hseigel, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/3436


More information about the hotspot-runtime-dev mailing list