RFR: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp

Yi Yang yyang at openjdk.java.net
Fri Apr 16 05:24:35 UTC 2021


On Fri, 16 Apr 2021 04:33:14 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Looks like these files refer to `(BytecodeCounter)|(BytecodeHistogram)(BytecodePairHistogram)` but are missing the inclusion of bytecodeHistogram.hpp
> 
> * cpu/aarch64/macroAssembler_aarch64.cpp
> * cpu/arm/macroAssembler_arm.cpp
> * cpu/x86/macroAssembler_x86.cpp
> 
> See https://github.com/iklam/tools/blob/main/headers/find_include_problems.sh
> 
> The problems can usually be found by building without precompiled headers.

Yes, the inclusion of bytecodeHistogram.hpp in sharedRuntime.hpp should remain, others are really unnecessary.(Build without precompile header)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3530


More information about the hotspot-runtime-dev mailing list