RFR: 8262953: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails if CPU quoata is not enabled

Severin Gehwolf sgehwolf at openjdk.java.net
Fri Apr 16 14:55:37 UTC 2021


On Fri, 16 Apr 2021 14:16:06 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> > > I can see config file in Fedora, Alpine, and Ubuntu. In case of Fedora, it is provided by kernel-core package. so I guess most of Linux distros are providing it. If so, I think we can throw SkipException when the test cannot find it.
> > 
> > 
> > Right. Note, however, `kernel-core` packages usually aren't installed in containers. So on a system like that (Raspberry Pi) and inside a container, the test would then be meaningless.
> 
> PlainTest.java does not require to run inside the container, it requires cgroups only. It does not use classes in `jdk.test.lib.containers.docker` like DockerBasicTest.java.
> The problem in PlainTest.java suffers only when `wb.isContainerized()` returns `true` - it does not indicates the process is inside container as we've discussed in #3280 .

Understood. Nothing precludes it from being run in a docker container, though, does it? I've seen test setups which only run jtreg tests in containers. I'm not convinced we need to add a dependency on the `kernel-core` package in order to fix this test, that's all I'm saying :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3206


More information about the hotspot-runtime-dev mailing list